improve CA and certificate generation #2834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change:
Recently during an audit on a user's cluster, it was discovered that
OLM's certificate generation functionality has a few minor shortcomings.
which causes some tooling to have trouble tracing the cert chain.
which means those certificates can be used for more than their
intended purposes.
Description of the change:
This commit resolves the above issues by ensuring the certificates
include common names and by using the minimal key usages necessary.
Testing remarks:
Thus far, I have only manually tested via
run-local
and verified that:Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue